[libvirt] [PATCH 19/41] remote: introduce virtproxyd daemon to handle IP connectivity

Andrea Bolognani abologna at redhat.com
Mon Jul 29 15:09:28 UTC 2019


On Mon, 2019-07-29 at 13:30 +0100, Daniel P. Berrangé wrote:
> On Sun, Jul 28, 2019 at 04:42:52PM +0200, Andrea Bolognani wrote:
> > On Tue, 2019-07-23 at 17:02 +0100, Daniel P. Berrangé wrote:
> > > +[Install]
> > > +WantedBy=multi-user.target
> > > +Also=virtproxyd.socket
> > > +Also=virtproxyd-ro.socket
> > 
> > Kind of a side note since it's pre-existing, but don't we want to
> > list virtproxyd-admin.socket here too?
> 
> It is redundant - the deps force virtproxyd-admin.socket to become
> enabled regardless.

Hm, yeah: we either want this to be socket activated, in which case
we'd have to enable the various sockets but not the service, or we
want it to start at boot, in which case enabling the sockets is
unnecessary.

Can you please drop the Also= lines for this as well as all other
virt*d.service files then?

-- 
Andrea Bolognani / Red Hat / Virtualization




More information about the libvir-list mailing list