[libvirt] [PATCH v3 13/48] remote: conditionalize IP socket config in augeas definitions

Andrea Bolognani abologna at redhat.com
Tue Jul 30 12:55:36 UTC 2019


On Mon, 2019-07-29 at 18:10 +0100, Daniel P. Berrangé wrote:
[...]
> +remote/libvirtd.aug: remote/libvirtd.aug.in
> +	$(AM_V_GEN)$(SED) \
> +		-e '/[@]CUT_ENABLE_IP[@]/d' \
> +		-e '/[@]END[@]/d' \
> +		-e 's|[@]DAEMON_NAME[@]|libvirtd|' \
> +		-e 's|[@]DAEMON_NAME_UC[@]|Libvirtd|' \
> +		$< > $@

See? You use the other form here.

>  remote/test_libvirtd.aug: remote/test_libvirtd.aug.in \
>  		remote/libvirtd.conf $(AUG_GENTEST)
> -	$(AM_V_GEN)$(AUG_GENTEST) remote/libvirtd.conf $< > $@
> +	$(AM_V_GEN)$(AUG_GENTEST) remote/libvirtd.conf \
> +		$(srcdir)/remote/test_libvirtd.aug.in | \
> +		$(SED) -e '/[@]CUT_ENABLE_IP[@]/d' \
> +		-e '/[@]END[@]/d' \
> +		-e 's|[@]DAEMON_NAME[@]|libvirtd|' \
> +		-e 's|[@]DAEMON_NAME_UC[@]|Libvirtd|' \
> +		> $@ || rm -f $@

The first -e argument to $(SED) should be on a separate line.

-- 
Andrea Bolognani / Red Hat / Virtualization




More information about the libvir-list mailing list