[libvirt] [PATCH v3 22/48] network: introduce virtnetworkd daemon

Daniel P. Berrangé berrange at redhat.com
Tue Jul 30 13:03:28 UTC 2019


On Tue, Jul 30, 2019 at 02:52:14PM +0200, Christophe de Dinechin wrote:
> 
> 
> > On 30 Jul 2019, at 13:20, Daniel P. Berrangé <berrange at redhat.com> wrote:
> > 
> > On Tue, Jul 30, 2019 at 01:08:53PM +0200, Christophe de Dinechin wrote:
> >> 
> >> Daniel P. Berrangé writes:
> >> 
> >>> The virtnetworkd daemon will be responsible for providing the network API
> >>> driver functionality. The network driver is still loaded by the main
> >>> libvirtd daemon at this stage, so virtnetworkd must not be running at
> >>> the same time.
> >>> 
> >>> Reviewed-by: Andrea Bolognani <abologna at redhat.com>
> >>> Signed-off-by: Daniel P. Berrangé <berrange at redhat.com>
> >>> ---
> >>> .gitignore                          |  4 ++
> >>> libvirt.spec.in                     |  8 ++++
> >>> src/network/Makefile.inc.am         | 61 +++++++++++++++++++++++++++++
> >>> src/network/virtnetworkd.service.in | 25 ++++++++++++
> >>> 4 files changed, 98 insertions(+)
> >>> create mode 100644 src/network/virtnetworkd.service.in
> >>> diff --git a/src/network/virtnetworkd.service.in b/src/network/virtnetworkd.service.in
> >>> new file mode 100644
> >>> index 0000000000..656e8b4f84
> >>> --- /dev/null
> >>> +++ b/src/network/virtnetworkd.service.in
> >>> @@ -0,0 +1,25 @@
> >>> +[Unit]
> >>> +Description=Virtualization network daemon
> >>> +Conflicts=libvirtd.service
> >>> +Requires=virtnetworkd.socket
> >>> +Requires=virtnetworkd-ro.socket
> >>> +Requires=virtnetworkd-admin.socket
> >>> +After=network.target
> >>> +After=dbus.service
> >>> +After=apparmor.service
> >>> +After=local-fs.target
> >>> +Documentation=man:libvirtd(8)
> >> 
> >> Maybe you need to create man page aliases for each of the new daemon names?
> > 
> > Yes, I need to figure out a way to auto-generate the man page for each
> > daemon with irrelevant content stripped.
> 
> Or simply refdirect to the original man page, using the .so macro?
> In which case you could generate the man page with a rule like:
> 
> 	echo “.so $LIBVIRTD_MANPAGE” > $@
> 
> (But then, maybe you really want per-daemon man page…)

Yes, some cli parameters are not valid with the new daemons, so we need to
trim those out of the man 

Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|




More information about the libvir-list mailing list