[libvirt] [PATCH v3 06/48] remote: stop trying to print help as giant blocks of text

[Christophe de Dinechin]

> On 30 Jul 2019, at 12:52, Andrea Bolognani <abologna at redhat.com> wrote:
> 
> On Mon, 2019-07-29 at 18:10 +0100, Daniel P. Berrangé wrote:
>> The remote daemon tries to print out its help text in a couple of giant
>> blocks of text. This has already lead to duplication of the text for the
>> privileged vs unprivileged execution mode. With the introduction of more
>> daemons, this text is going to be duplicated many more times with small
>> variations. This is very unfriendly to translators as they have to
>> translate approximately the same text many times with small tweaks.
>> 
>> Splitting the text up into individual strings to print means that each
>> piece will only need translating once. It also gets rid of all the
>> layout information from the translated strings, so avoids the problem of
>> translators breaking formatting by mistake.
>> 
>> Signed-off-by: Daniel P. Berrangé <berrange at redhat.com>
>> ---
>> src/remote/remote_daemon.c | 128 ++++++++++++++++++-------------------
>> src/remote/remote_driver.h |   1 -
>> 2 files changed, 64 insertions(+), 65 deletions(-)
> 
> While I'm sympathetic to Christophe's plead for being nicer to French
> users and translators, right now I'd like to avoid another respin of
> this already pretty big series, so whether you address the changes he
> asked for before pushing or as a follow-up patch you still get a
>  Reviewed-by: Andrea Bolognani <abologna at redhat.com>

Fine with me either way.

> 
> -- 
> Andrea Bolognani / Red Hat / Virtualization
> 
> --
> libvir-list mailing list
> libvir-list at redhat.com
> https://www.redhat.com/mailman/listinfo/libvir-list