[libvirt] [PATCH v2 1/7] qemu: Make virQEMUCapsProbeHostCPUForEmulator more generic

Ján Tomko jtomko at redhat.com
Mon Jun 3 12:38:52 UTC 2019


On Mon, Jun 03, 2019 at 02:27:52PM +0200, Jiri Denemark wrote:
>The function is renamed as virQEMUCapsProbeHostCPU and it does not get
>the list of allowed CPU models from qemuCaps anymore. This is
>responsibility is moved to the caller. The result is just a very thin
>wrapper around virCPUGetHost mostly required mocking in tests.
>
>The generic function is used in place of a direct call to virCPUGetHost
>in virQEMUCapsInitHostCPUModel to make sure tests don't accidentally
>probe host CPU.
>
>Signed-off-by: Jiri Denemark <jdenemar at redhat.com>
>---
> src/qemu/qemu_capabilities.c | 14 ++++++--------
> src/qemu/qemu_capspriv.h     |  5 ++---
> tests/qemucpumock.c          |  5 ++---
> 3 files changed, 10 insertions(+), 14 deletions(-)
>

Reviewed-by: Ján Tomko <jtomko at redhat.com>

Jano
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20190603/a24e028b/attachment-0001.sig>


More information about the libvir-list mailing list