[libvirt] [PATCH 01/19] device-conf: removed unneeded virDomainDeviceInfoCopy()

marcandre.lureau at redhat.com marcandre.lureau at redhat.com
Wed Jun 5 10:30:59 UTC 2019


From: Marc-André Lureau <marcandre.lureau at redhat.com>

Signed-off-by: Marc-André Lureau <marcandre.lureau at redhat.com>
---
 src/conf/device_conf.c   | 21 ---------------------
 src/conf/device_conf.h   |  2 --
 src/libvirt_private.syms |  1 -
 3 files changed, 24 deletions(-)

diff --git a/src/conf/device_conf.c b/src/conf/device_conf.c
index 2f82bdc2a7..b28f30dfc5 100644
--- a/src/conf/device_conf.c
+++ b/src/conf/device_conf.c
@@ -86,27 +86,6 @@ virZPCIDeviceAddressParseXML(xmlNodePtr node,
     return ret;
 }
 
-int
-virDomainDeviceInfoCopy(virDomainDeviceInfoPtr dst,
-                        virDomainDeviceInfoPtr src)
-{
-    /* Assume that dst is already cleared */
-
-    /* first a shallow copy of *everything* */
-    *dst = *src;
-
-    /* then copy whatever's left */
-    dst->alias = NULL;
-    dst->romfile = NULL;
-    dst->loadparm = NULL;
-
-    if (VIR_STRDUP(dst->alias, src->alias) < 0 ||
-        VIR_STRDUP(dst->romfile, src->romfile) < 0 ||
-        VIR_STRDUP(dst->loadparm, src->loadparm) < 0)
-        return -1;
-    return 0;
-}
-
 void
 virDomainDeviceInfoClear(virDomainDeviceInfoPtr info)
 {
diff --git a/src/conf/device_conf.h b/src/conf/device_conf.h
index b3299ac69d..54db244f0e 100644
--- a/src/conf/device_conf.h
+++ b/src/conf/device_conf.h
@@ -182,8 +182,6 @@ struct _virDomainDeviceInfo {
     bool isolationGroupLocked;
 };
 
-int virDomainDeviceInfoCopy(virDomainDeviceInfoPtr dst,
-                            virDomainDeviceInfoPtr src);
 void virDomainDeviceInfoClear(virDomainDeviceInfoPtr info);
 void virDomainDeviceInfoFree(virDomainDeviceInfoPtr info);
 
diff --git a/src/libvirt_private.syms b/src/libvirt_private.syms
index 8ee76645cd..b0dbf399eb 100644
--- a/src/libvirt_private.syms
+++ b/src/libvirt_private.syms
@@ -105,7 +105,6 @@ virDomainDeviceCCWAddressIsValid;
 virDomainDeviceCCWAddressParseXML;
 virDomainDeviceDriveAddressParseXML;
 virDomainDeviceInfoAddressIsEqual;
-virDomainDeviceInfoCopy;
 virDomainDeviceSpaprVioAddressParseXML;
 virDomainDeviceUSBAddressParseXML;
 virDomainDeviceVirtioSerialAddressParseXML;
-- 
2.22.0.rc2.384.g1a9a72ea1d




More information about the libvir-list mailing list