[libvirt] [PATCH 00/13] qemu: External disk snapshot code refactors/cleanups (blockdev-add saga)

Peter Krempa pkrempa at redhat.com
Wed Jun 5 15:28:22 UTC 2019


Few cleanups to the snapshot code extracted from my blockdev branch.

Peter Krempa (13):
  qemu: snapshot: Pass 'cfg' to external snapshot functions
  qemu: Use VIR_AUTOPTR in qemuDomainSnapshotCreateDiskActive
  qemu: Use virErrorPreserveLast in qemuDomainSnapshotCreateDiskActive
  qemu: Use VIR_AUTO* in qemuDomainSnapshotCreateActiveExternal
  qemu: snapshot: Remove unused cleanup section in
    qemuDomainSnapshotCreateSingleDiskActive
  qemu: snapshot: Always save status and config after
    qemuDomainSnapshotCreateDiskActive
  qemu: snapshot: Always save config XML after
    qemuDomainSnapshotCreateDiskActive
  qemu: snapshot: Densely pack data in qemuDomainSnapshotDiskDataCollect
  qemu: snapshot: Move all cleanup of snapshot disk data to
    qemuDomainSnapshotDiskDataFree
  qemu: snapshot: Don't overload 'ret' in
    qemuDomainSnapshotCreateDiskActive
  qemu: snapshot: Unify 'cleanup' and 'error' in
    qemuDomainSnapshotCreateDiskActive
  qemu: snapshot: Return early if there's nothing to snapshot
  qemu: snapshot: Remove unnecessary 'do_transaction' logic in
    qemuDomainSnapshotCreateDiskActive

 src/qemu/qemu_driver.c | 189 +++++++++++++++++------------------------
 1 file changed, 79 insertions(+), 110 deletions(-)

-- 
2.21.0




More information about the libvir-list mailing list