[libvirt] [PATCH 3/4] backup: Add new qemu monitor bitmap

[Eric Blake]

On 6/6/19 7:48 AM, Peter Krempa wrote:
> On Wed, Jun 05, 2019 at 22:01:09 -0500, Eric Blake wrote:
>> The upcoming virDomainBackup() API needs to take advantage of various
>> qcow2 bitmap manipulations as the basis to virDomainCheckpoints and
>> incremental backups.  Add four functions to expose
>> block-dirty-bitmap-{add,enable,disable,merge} (this is the
>> recently-added QEMU_CAPS_BITMAP_MERGE capability).
>>
>> Signed-off-by: Eric Blake <eblake at redhat.com>
>> ---
>>  src/qemu/qemu_monitor.h      |  19 ++++++
>>  src/qemu/qemu_monitor_json.h |  17 +++++
>>  src/qemu/qemu_monitor.c      |  51 +++++++++++++++
>>  src/qemu/qemu_monitor_json.c | 119 +++++++++++++++++++++++++++++++++++
>>  4 files changed, 206 insertions(+)
> 
> I'd suggest you add GEN_TEST_FUNC/DO_TEST_GEN tests for those. It's
> simple to add and gives you checking of the arguments against the QAPI
> schema for free.

Will do. Do you need to see the amended patch with that added, or should
I go ahead and push once I have it working?

-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3226
Virtualization:  qemu.org | libvirt.org

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: OpenPGP digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20190606/8b5c16a6/attachment-0001.sig>