[libvirt] [PATCH 2/2] gitdm: Add gitdm configuration

Fri Jun 7 10:34:42 UTC 2019

On Thu, Jun 06, 2019 at 04:47:59PM +0200, Andrea Bolognani wrote:
>This configuration can be used by gitdm to generate reports about
>libvirt development.
>
>The goal I was working with was being able to generate a report
>for every single libvirt release and having zero "email address
>as company" entries; picking different commit ranges might result
>in some contributions not being accounted for.
>
>I had to make some judgement calls when the situation was not
>entirely clear-cut: when in doubt, and not finding any obvious
>signs of the opposite being true, I mostly ended up dumping
>people in the "unaffiliated contributions" bin. If I got it
>wrong, and companies want to get recognition for their sponsored
>contributions to libvirt, they can send patches.
>
>Signed-off-by: Andrea Bolognani <abologna at redhat.com>
>---
> docs/gitdm/aliases             | 25 +++++++++
> docs/gitdm/companies/canonical | 11 ++++
> docs/gitdm/companies/datto     |  2 +
> docs/gitdm/companies/dreamhost |  4 ++
> docs/gitdm/companies/nec       |  2 +
> docs/gitdm/companies/others    | 98 ++++++++++++++++++++++++++++++++++
> docs/gitdm/companies/redhat    |  6 +++
> docs/gitdm/companies/suse      |  7 +++
> docs/gitdm/companies/virtuozzo |  2 +
> docs/gitdm/groups/education    | 17 ++++++
> docs/gitdm/groups/opensource   | 12 +++++
> docs/gitdm/groups/unaffiliated | 83 ++++++++++++++++++++++++++++
> gitdm.config                   | 37 +++++++++++++
> 13 files changed, 306 insertions(+)
> create mode 100644 docs/gitdm/aliases
> create mode 100644 docs/gitdm/companies/canonical
> create mode 100644 docs/gitdm/companies/datto
> create mode 100644 docs/gitdm/companies/dreamhost
> create mode 100644 docs/gitdm/companies/nec
> create mode 100644 docs/gitdm/companies/others
> create mode 100644 docs/gitdm/companies/redhat
> create mode 100644 docs/gitdm/companies/suse
> create mode 100644 docs/gitdm/companies/virtuozzo
> create mode 100644 docs/gitdm/groups/education
> create mode 100644 docs/gitdm/groups/opensource
> create mode 100644 docs/gitdm/groups/unaffiliated
> create mode 100644 gitdm.config
>
>diff --git a/docs/gitdm/aliases b/docs/gitdm/aliases
>new file mode 100644
>index 0000000000..c3c837f89f
>--- /dev/null
>+++ b/docs/gitdm/aliases
>@@ -0,0 +1,25 @@
>+# Silly mistakes, mostly found in S-o-b or R-b tags.
>+
>+"jdenemar redhat com" jdenemar at redhat.com
>+"pkrempa at redhat st.com" pkrempa at redhat.com
>+jyang at redhat jyang at redhat.com
>+wangjie88.huawei.com wangjie88 at huawei.com
>+
>+# This is information that's already present in .mailmap, and having to
>+# duplicate it is annoying. Unfortunately gitdm doesn't parse .mailmap
>+# and the format is different, so we can't just point it to the file
>+# either.
>+

Isn't the point of the files different? With .mailmap mapping multiple
addresses to one person and this file mapping it to this person's
employment?

>+cedric.bosdonnat at free.fr cbosdonnat at suse.com
>+dan at berrange.com berrange at redhat.com
>+fabiano at fidencio.org fidencio at redhat.com
>+intrigeri+libvirt at boum.org intrigeri at boum.org
>+jim at meyering.net meyering at redhat.com

IIRC Jim no longer works at Red Hat

>+laine at laine.org laine at redhat.com
>+redhat at adrb.pl adrian.brzezinski at eo.pl
>+shilei.massclouds at gmx.com shi_lei at massclouds.com
>+
>+# This deviates from what's found in .mailmap, but it makes more sense as
>+# far as gitdm is concerned since Jim was employed by Novell at the time.
>+
>+jfehlig at linux-ypgk.site jfehlig at novell.com
>diff --git a/docs/gitdm/companies/canonical b/docs/gitdm/companies/canonical
>new file mode 100644
>index 0000000000..3e7e59331f
>--- /dev/null
>+++ b/docs/gitdm/companies/canonical
>@@ -0,0 +1,11 @@
>+canonical.com
>+
>+# Having an @ubuntu.com email address doesn't necessarily imply you're a
>+# Canonical employer; these people, however, seemed to be employed by

employee

>+# Canonical at the time they contributed to libvirt.
>+
>+jamie at ubuntu.com
>+serge.hallyn at ubuntu.com
>+smoser at ubuntu.com
>+soren at ubuntu.com
>+wgrant at ubuntu.com
>diff --git a/docs/gitdm/companies/redhat b/docs/gitdm/companies/redhat
>new file mode 100644
>index 0000000000..d3016619c5
>--- /dev/null
>+++ b/docs/gitdm/companies/redhat
>@@ -0,0 +1,6 @@
>+redhat.com
>+
>+# These Red Hat employers used their personal email address when contributing

employees

>+# to libvirt and we don't have the corresponding @redhat.com address on file.
>+
>+lkundrak at v3.sk
>diff --git a/docs/gitdm/companies/suse b/docs/gitdm/companies/suse
>new file mode 100644
>index 0000000000..f1fe154c41
>--- /dev/null
>+++ b/docs/gitdm/companies/suse
>@@ -0,0 +1,7 @@
>+suse.com
>+suse.de
>+
>+# These SUSE employers used their personal email address when contributing

employees

>+# to libvirt and we don't have the corresponding @suse.com address on file.
>+
>+olaf at aepfle.de
>diff --git a/docs/gitdm/groups/unaffiliated b/docs/gitdm/groups/unaffiliated
>new file mode 100644
>index 0000000000..f492737070
>--- /dev/null
>+++ b/docs/gitdm/groups/unaffiliated

[...]

>+rufo at rufoa.com
>+slawek at kaplonski.pl
>+soulxu at soulxu-thinkpad-t410.(none)

Hmm...

>+stybla at turnovfree.net
>+tai at rakugaki.org
>+thomas at scripty.at
>+v.tolstov at selfip.ru
>+ville.skytta at iki.fi
>+vincent at bernat.im
>+wido at widodh.nl
>+wiedi at frubar.net
>+wongc-redhat at hoku.net
>+xschen at tnsoft.com.cn
>+yurchor at ukr.net
>diff --git a/gitdm.config b/gitdm.config
>new file mode 100644
>index 0000000000..e4101bbc34
>--- /dev/null
>+++ b/gitdm.config
>@@ -0,0 +1,37 @@
>+# gitdm config for libvirt
>+# ------------------------
>+#
>+# Generate statistic for eg. v4.6.0 by running
>+#
>+#   $ git log -p -M v4.5.0..v4.6.0 | gitdm

gitdm does not seem to be packaged by distros, can you link to the git
here?

Also, I had an issue with parsing logs using dates in the ISO format,
can you add --date=rfc to the example?

Reviewed-by: Ján Tomko <jtomko at redhat.com>

Jano
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20190607/03e81d50/attachment-0001.sig>