[libvirt] [PATCH] test_driver: implement virConnectGetLibVersion

[Peter Krempa]

On Mon, Jun 10, 2019 at 15:34:57 +0200, Erik Skultety wrote:
> On Mon, Jun 10, 2019 at 02:38:15PM +0200, Ilias Stamatis wrote:
> > Signed-off-by: Ilias Stamatis <stamatis.iliass at gmail.com>
> > ---
> >  src/test/test_driver.c | 9 +++++++++
> >  1 file changed, 9 insertions(+)
> >
> > diff --git a/src/test/test_driver.c b/src/test/test_driver.c
> > index 1aa79ce898..dc267b6ecd 100644
> > --- a/src/test/test_driver.c
> > +++ b/src/test/test_driver.c
> > @@ -1453,6 +1453,14 @@ static char *testConnectGetHostname(virConnectPtr conn ATTRIBUTE_UNUSED)
> >  }
> >
> >
> > +static int testConnectGetLibVersion(virConnectPtr conn ATTRIBUTE_UNUSED,
> > +                                    unsigned long *libVer)
> > +{
> > +    *libVer = LIBVIR_VERSION_NUMBER;
> > +    return 0;
> > +}
> 
> Test driver is implemented entirely on the client side, so implementing this
> API is unnecessary, since the public API returns the value in the client
> library if a specific driver doesn't implement it. If test driver was
> implemented within the daemon, then it could be different, but in this case it

Note that you can access the test driver also remotely:

$ virsh -c test+ssh://root@localhost/default 
root at localhost's password: 
Welcome to virsh, the virtualization interactive terminal.

Type:  'help' for help with commands
       'quit' to quit

virsh # list --all
 Id   Name   State
----------------------
 1    test   running

virsh # version --daemon
Compiled against library: libvirt 5.1.0
Using library: libvirt 5.1.0
Using API: TEST 5.1.0
Running hypervisor: TEST 0.0.2
Running against daemon: 5.5.0

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20190610/d4684bee/attachment-0001.sig>