[libvirt] [PATCH 1/4] backup: Prepare for Unix sockets in QMP nbd-server-start

[Peter Krempa]

On Mon, Jun 10, 2019 at 12:11:34 -0500, Eric Blake wrote:
> On 6/7/19 7:06 AM, Peter Krempa wrote:
> > On Fri, Jun 07, 2019 at 10:13:04 +0200, Peter Krempa wrote:
> >> On Thu, Jun 06, 2019 at 08:40:14 -0500, Eric Blake wrote:
> >>> On 6/6/19 7:53 AM, Peter Krempa wrote:
> > 
> > [...]
> > 
> >> In this case I feel it's more useful to do the check against the schema
> >> rather than to see that the resposne is the same.
> >>
> >> Alternatively I can see whether it's reasonably feasible to do schema
> >> checking also in qemuMonitorTestAddItemVerbatim.
> > 
> > https://www.redhat.com/archives/libvir-list/2019-June/msg00210.html
> > 
> > So we can keep using qemuMonitorTestAddItemVerbatim here.
> 
> AddItemVerbatim is a pain to maintain; I'd rather stick with AddItem +
> schema checks. But in doing that, I found that a lot of existing code in
> the test did not do schema tests; hence I'm planning on pushing these
> four patches (amended per your review) only after a prerequisite fix of

I agree. If there isn't a particular reason to check the data on the
monitor as well, using the AddItem is sufficient when we do a schema
check.

The AddItemVerbatim function makes sense when we couple it with
functional testing of other code as well where we need to validate that
libvirt's commands are correct as well e.g. as we do for the cpu hotplug
tests.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20190611/5f703d46/attachment-0001.sig>