[libvirt] [PATCH 1/3] qemu: domain: Fix logic bug in qemuDomainStorageSourceAccessAllow

Ján Tomko jtomko at redhat.com
Tue Jun 11 15:44:14 UTC 2019


On Tue, Jun 11, 2019 at 04:56:23PM +0200, Peter Krempa wrote:
>In commit 76b9aba2ba6 I tried to refactor qemuDomainStorageSourceAccessAllow
>but used wrong operators for adding bitwise flags.
>

How did that get past review? O:-)

>This way the flags would result in 0 if any of them would be applied.
>
>Signed-off-by: Peter Krempa <pkrempa at redhat.com>
>---
> src/qemu/qemu_domain.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>

Reviewed-by: Ján Tomko <jtomko at redhat.com>

Jano
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20190611/98c2e153/attachment-0001.sig>


More information about the libvir-list mailing list