[libvirt] [PATCH 3/3] qemu: Use proper block job name when reconnecting to VM

Ján Tomko jtomko at redhat.com
Tue Jun 11 15:46:02 UTC 2019


On Tue, Jun 11, 2019 at 04:56:25PM +0200, Peter Krempa wrote:
>The hash table returned by qemuMonitorGetAllBlockJobInfo is organized by
>the frontend name (which skipps the 'drive-' prefix). While our code
>properly matches the jobs to the disk, qemu needs the full job name
>including the 'drive-' prefix to be able to identify jobs.
>
>Fix this by adding an argument to qemuMonitorGetAllBlockJobInfo which
>does not modify the job name before filling the hash.
>
>This fixes a regression where users would not be able to cancel/pivot
>block jobs after restarting libvirtd while a blockjob is running.
>
>Signed-off-by: Peter Krempa <pkrempa at redhat.com>
>---
> src/qemu/qemu_migration.c    |  2 +-
> src/qemu/qemu_monitor.c      |  7 ++++---
> src/qemu/qemu_monitor.h      |  3 ++-
> src/qemu/qemu_monitor_json.c | 12 ++++++++----
> src/qemu/qemu_monitor_json.h |  3 ++-
> src/qemu/qemu_process.c      |  2 +-
> 6 files changed, 18 insertions(+), 11 deletions(-)
>

Reviewed-by: Ján Tomko <jtomko at redhat.com>

Jano
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20190611/e6a9a63b/attachment-0001.sig>


More information about the libvir-list mailing list