[libvirt] [PATCH] qemu: domain: Log some useful data in qemuDomainStorageSourceAccessModify

[Ján Tomko]

On Wed, Jun 12, 2019 at 01:53:39PM +0200, Peter Krempa wrote:
>Log the flags passed to the function in a exploded state so that it's

s/a exploded/an exploded/

>easily visible what's happening to the image.
>
>Signed-off-by: Peter Krempa <pkrempa at redhat.com>
>---
> src/qemu/qemu_domain.c | 13 ++++++++++---
> 1 file changed, 10 insertions(+), 3 deletions(-)
>
>diff --git a/src/qemu/qemu_domain.c b/src/qemu/qemu_domain.c
>index 2095191cde..d28cfa4f42 100644
>--- a/src/qemu/qemu_domain.c
>+++ b/src/qemu/qemu_domain.c
>@@ -9339,6 +9339,9 @@ qemuDomainStorageSourceAccessModify(virQEMUDriverPtr driver,
>     int ret = -1;
>     virErrorPtr orig_err = NULL;
>     bool chain = flags & QEMU_DOMAIN_STORAGE_SOURCE_ACCESS_CHAIN;
>+    bool force_ro = flags & QEMU_DOMAIN_STORAGE_SOURCE_ACCESS_FORCE_READ_ONLY;
>+    bool force_rw = flags & QEMU_DOMAIN_STORAGE_SOURCE_ACCESS_FORCE_READ_WRITE;
>+    bool revoke = flags & QEMU_DOMAIN_STORAGE_SOURCE_ACCESS_REVOKE;
>     int rc;
>     bool was_readonly = src->readonly;
>     bool revoke_cgroup = false;
>@@ -9346,14 +9349,18 @@ qemuDomainStorageSourceAccessModify(virQEMUDriverPtr driver,
>     bool revoke_namespace = false;
>     bool revoke_lockspace = false;
>
>-    if (flags & QEMU_DOMAIN_STORAGE_SOURCE_ACCESS_FORCE_READ_ONLY)
>+    VIR_DEBUG("VM: '%s', src: '%s', readonly: '%d, force_ro: '%d', force_rw: '%d', revoke: '%d', chain: '%d'",

We usually use lowercase 'vm' in the logs. Also, the readonly attribue
has a mismatched attribute.

How about the more compact format we use elsewhere:
    VIR_DEBUG("VM='%s', src='%s', readonly=%d force_ro=%d force_rw=%d revoke=%d chain=%d".

>+              vm->def->name, NULLSTR(src->path), src->readonly, force_ro,
>+              force_rw, revoke, chain);
>+

Reviewed-by: Ján Tomko <jtomko at redhat.com>

Jano
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20190612/e98ae782/attachment-0001.sig>