[libvirt] [PATCH 00/19] Use '#pragma once' in headers

Jonathon Jongsma jjongsma at redhat.com
Thu Jun 13 19:33:55 UTC 2019


On Thu, 2019-06-13 at 10:23 -0500, Eric Blake wrote:
> On 6/13/19 10:06 AM, Ján Tomko wrote:
> 
> > > Jonathon Jongsma (19):
> > >  Use #pragma once in driver headers
> > >  src/access: use #pragma once in headers
> > >  src/admin: use #pragma once in headers
> > >  src/bhyve: use #pragma once in headers
> > >  conf: domain: use #pragma once in headers
> > >  conf: network: use #pragma once in headers
> > >  conf: nwfilter: use #pragma once in headers
> > >  conf: node device: use #pragma once in headers
> > >  conf: storage: use #pragma once in headers
> > >  conf: misc: use #pragma once in headers
> > >  src/cpu: use #pragma once in headers
> > >  src/datatypes.h: use #pragma once
> > >  src/esx: use #pragma once in headers
> > >  src/hyperv: use #pragma once in headers
> > >  src/interface: use #pragma once in headers
> > >  src/internal.h: use #pragma once
> > >  src/libvirt_internal.h: use #pragma once
> > >  src/libxl: use #pragma once in headers
> > >  src/logging: use #pragma once in headers
> > > 
> 
> Does this series add a syntax-check rule to prevent reversion back to
> older styles when new files are introduced?  For example, I now have
> to
> rebase my pending incremental backup work on top of this, which adds
> new
> files, but without a syntax-check rule addition, I can't quickly
> identify which files I plan to add that need a tweak.

Good point. I did not add a syntax check yet. In fact, this is not even
the complete patch series. The whole patch series is actually about 60
patches, but I didn't want to flood the mailing list right away on my
first submission. So I just sent the first 20 or so in case people
wanted to split them up differently. I can try to add a syntax check to
include when I send the rest of the series.

> 
> > Reviewed-by: Ján Tomko <jtomko at redhat.com>
> > and pushed.
> Thus, it would be a nice followup patch for you to work on.
> 

Sure thing.

Jonathon




More information about the libvir-list mailing list