[libvirt] [PATCH 4/7] tests: Add pseries-spaprvio-invalid

Andrea Bolognani abologna at redhat.com
Fri Jun 14 11:23:28 UTC 2019


This test case shows that we now reject invalid spapr-vio
addresses.

Signed-off-by: Andrea Bolognani <abologna at redhat.com>
---
 .../pseries-spaprvio-invalid.xml                | 17 +++++++++++++++++
 tests/qemuxml2argvtest.c                        |  1 +
 2 files changed, 18 insertions(+)
 create mode 100644 tests/qemuxml2argvdata/pseries-spaprvio-invalid.xml

diff --git a/tests/qemuxml2argvdata/pseries-spaprvio-invalid.xml b/tests/qemuxml2argvdata/pseries-spaprvio-invalid.xml
new file mode 100644
index 0000000000..cd658e314b
--- /dev/null
+++ b/tests/qemuxml2argvdata/pseries-spaprvio-invalid.xml
@@ -0,0 +1,17 @@
+<domain type='qemu'>
+  <name>guest</name>
+  <uuid>b35969f7-e7cf-4d90-a9a0-4dd9000f9824</uuid>
+  <memory unit='KiB'>4194304</memory>
+  <vcpu placement='static'>4</vcpu>
+  <os>
+    <type arch='ppc64le' machine='pseries'>hvm</type>
+  </os>
+  <devices>
+    <emulator>/usr/bin/qemu-system-ppc64</emulator>
+    <serial type='pty'>
+      <!-- spapr-vio addresses are 32-bit, so they can go up to 0xffffffff:
+           the value below is too big and should be rejected -->
+      <address type='spapr-vio' reg='0x0000000100000000'/>
+    </serial>
+  </devices>
+</domain>
diff --git a/tests/qemuxml2argvtest.c b/tests/qemuxml2argvtest.c
index 49220733ae..6a75d663c5 100644
--- a/tests/qemuxml2argvtest.c
+++ b/tests/qemuxml2argvtest.c
@@ -1898,6 +1898,7 @@ mymain(void)
     DO_TEST("pseries-console-virtio",
             QEMU_CAPS_DEVICE_SPAPR_PCI_HOST_BRIDGE);
     DO_TEST_PARSE_ERROR("pseries-serial-invalid-machine", NONE);
+    DO_TEST_PARSE_ERROR("pseries-spaprvio-invalid", "ppc64");
 
     DO_TEST("mach-virt-serial-native",
             QEMU_CAPS_DEVICE_PL011);
-- 
2.21.0




More information about the libvir-list mailing list