[libvirt] [RFC PATCH 5/5] qemu: parse: Drop unused qemu command line parsing infrastructure

Ján Tomko jtomko at redhat.com
Fri Jun 14 13:52:11 UTC 2019


On Fri, Jun 14, 2019 at 03:30:27PM +0200, Peter Krempa wrote:
>It's now unused and utterly obsolete.
>
>Signed-off-by: Peter Krempa <pkrempa at redhat.com>
>---
> src/qemu/qemu_domain.c        |    2 +
> src/qemu/qemu_parse_command.c | 2622 +--------------------------------
> src/qemu/qemu_parse_command.h |   16 -
> 3 files changed, 3 insertions(+), 2637 deletions(-)
>
>diff --git a/src/qemu/qemu_domain.c b/src/qemu/qemu_domain.c
>index e5c6ef3fda..8f754fbf06 100644
>--- a/src/qemu/qemu_domain.c
>+++ b/src/qemu/qemu_domain.c
>@@ -76,6 +76,8 @@
>
> #define VIR_FROM_THIS VIR_FROM_QEMU
>
>+#define QEMU_QXL_VGAMEM_DEFAULT 16 * 1024
>+
> VIR_LOG_INIT("qemu.qemu_domain");
>

The move of this constant does not seem to be relevant to the rest of
the patch. Please separate it.

Jano
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20190614/47217fa6/attachment-0001.sig>


More information about the libvir-list mailing list