[libvirt] [PATCH 04/12] tests: qemuMonitorTestProcessCommandDefaultValidate: simplify condition
Peter Krempa
pkrempa at redhat.com
Mon Jun 17 06:57:46 UTC 2019
On Sat, Jun 15, 2019 at 13:54:02 +0200, Ján Tomko wrote:
> This function is skipped for non-JSON monitor (which never happens now)
> and for agent connections (which we currently do not test).
>
> Only check for qapischema to simplify the condition.
>
> Signed-off-by: Ján Tomko <jtomko at redhat.com>
> ---
> tests/qemumonitortestutils.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tests/qemumonitortestutils.c b/tests/qemumonitortestutils.c
> index bb30bed51e..cf4fec8873 100644
> --- a/tests/qemumonitortestutils.c
> +++ b/tests/qemumonitortestutils.c
> @@ -546,7 +546,7 @@ qemuMonitorTestProcessCommandDefaultValidate(qemuMonitorTestPtr test,
> char *schemapath = NULL;
> int ret = -1;
>
> - if (!test->qapischema || !test->json || test->agent)
> + if (!test->qapischema)
The check for test->agent is necessary, since we don't know how to
validate the agent monitor schema.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20190617/691e43bd/attachment-0001.sig>
More information about the libvir-list
mailing list