[libvirt] [PATCH v4 08/25] tools: Slightly rework libvirt_recover_xattrs.sh

Daniel P. Berrangé berrange at redhat.com
Mon Jun 17 13:20:11 UTC 2019


On Thu, Apr 25, 2019 at 10:19:44AM +0200, Michal Privoznik wrote:
> Firstly, there's no reason to enumerate all XATTRs since they
> differ only in the prefix and we can construct them in a loop.
> 
> Secondly, and more importantly, the script was still looking for
> just one prefix "trusted.libvirt.security" even on FreeBSD.
> 
> Signed-off-by: Michal Privoznik <mprivozn at redhat.com>
> Reviewed-by: Cole Robinson <crobinso at redhat.com>
> ---
>  tools/libvirt_recover_xattrs.sh | 50 ++++++++++++++++-----------------
>  1 file changed, 25 insertions(+), 25 deletions(-)

Reviewed-by: Daniel P. Berrangé <berrange at redhat.com>


Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|




More information about the libvir-list mailing list