[libvirt] [PATCH 0/4] docs: Use CDNJS, update JavaScript libraries

[Peter Krempa]

On Tue, Jun 18, 2019 at 10:39:40 +0100, Daniel Berrange wrote:
> On Tue, Jun 18, 2019 at 11:19:20AM +0200, Andrea Bolognani wrote:
> > On Tue, 2019-06-18 at 09:48 +0100, Daniel P. Berrangé wrote:
> > > On Tue, Jun 18, 2019 at 10:12:39AM +0200, Andrea Bolognani wrote:
> > > > We're carrying around embedded copies of a few JavaScript libraries
> > > > for use in our homepage, and we've been unforgivably bad at keeping
> > > > them up to date.
> > > > 
> > > > Instead of serving JavaScript from libvirt.org, use CDNJS so that
> > > > users will get better performance and the load on our Web server
> > > > will decrease (win-win!); at the same time, move from the positively
> > > > ancient versions we're currently using to the freshest ones
> > > > available.
> > > 
> > > I'm in favour of updating the code of course, but I'd like to keep it
> > > self-contained on our own site, certainly not support cloudflare.
> > 
> > Why? CDNJS is a completely open source project that just so happens
> > to be hosted on, and sponsored by, CloudFlare.
> 
> I don't see us having any real problem with self-hosting the content
> we have done since this was first added. There's not much of it, our
> site is not a high traffic site, and we've got many much larger files
> hosted.
> 
> > Including minimized JavaScript files in release archives as we're
> > doing right now is also pretty sketchy, since it's basically the same
> > as shipping pre-built binaries instead of the corresponding sources.
> > Debian has a fairly strict policy against it, which is how I came to
> > realized it was an issue in the first place, but I'd be surprised if
> > other distributions were happy with the situation.
> 
> I'm fine if we put non-minimized JS in GIT & (optionally) minimize  it
> during build.

But what's the point of having it in git of libvirt? I can understand
that we generate the docs from there. But we don't really need JS for
the docs.

The main page and everything is by itself pretty weird to be in
libvirt.git
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20190618/574cde5d/attachment-0001.sig>