[libvirt] [PATCH 0/4] docs: Use CDNJS, update JavaScript libraries

Daniel P. Berrangé berrange at redhat.com
Tue Jun 18 12:28:37 UTC 2019


On Tue, Jun 18, 2019 at 02:23:28PM +0200, Andrea Bolognani wrote:
> On Tue, 2019-06-18 at 11:53 +0100, Daniel P. Berrangé wrote:
> > On Tue, Jun 18, 2019 at 12:15:46PM +0200, Andrea Bolognani wrote:
> > > That would be an improvement on the current situation, but it would
> > > also mean hooking up a JavaScript minifier to our build system. I'm
> > > not quite sure how those things work, but I think the ones that are
> > > widely used depend on node.js and who knows how many nano-libraries
> > > pulled from NPM to do their thing?
> > 
> > Fedora has uglify-js RPM present in its repos which is trivial
> > to install & use
> > 
> >  $ uglify-js foo.js > foo.min.js
> > 
> > If a distro lacks this package, simply don't minimize it.
> 
> Alright, I'll admit that's not as bad as I feared :)
> 
> > > Counter-proposal: can we just get rid of the RSS widget from the
> > > homepage? That's literally the only reason we included all this
> > > JavaScript in the first place. It's cute, but possibly not worth
> > > the effort if you take into account having to spend time keeping up
> > > with updates to jQuery and friends, which if history is any
> > > indication we'd do a pretty awful job at anyway.
> > > 
> > > As a data point, the QEMU website provides a link to Planet Virt
> > > Tools in its footer. We could do the same: we even already have a
> > > bunch of links there.
> > 
> > Hiding a link in the footer is really poor in comparison. The point
> > of having the feed content on the website is that it gives direct
> > visibility to visitors of the site. Far fewer will notice & follow
> > a link in the footer. We need to be improving visibility of relevant
> > content, not making it worse.
> > 
> > Updating jQuery is not a burden / timesink. It is something we
> > haven't considered a priority to bother with as it has just worked
> > fine. So there's no compelling reason to remove it when it is
> > serving an important use case.
> 
> I'm okay with having links to Planet Virt Tools very visible, but I
> disagree that the only way to achieve that is through a JavaScript
> powered blog roll.
> 
> For example, we could keep the third column of the homepage and
> rename it to "Community", then move all the "Community" links from
> the footer to that column. Pretty visible still, and no JavaScript,
> 
> Would you consider that acceptable?

Well its better than everything in the footer, but I still believe it
is significantly worse than what we have already.

Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|




More information about the libvir-list mailing list