[libvirt] [PATCH v3 0/5] docs: Update third-party JavaScript libraries

Christophe de Dinechin cdupontd at redhat.com
Thu Jun 20 10:35:50 UTC 2019



> On 20 Jun 2019, at 12:25, Andrea Bolognani <abologna at redhat.com> wrote:
> 
> On Wed, 2019-06-19 at 17:00 +0200, Christophe de Dinechin wrote:
>>> Andrea Bolognani (5):
>>> docs: Update jQuery
>>> docs: Update Moment.js
>>> docs: Update jquery.rss
>>> docs: Perform JavaScript minimization at build time
>>> spec: Require uglifyjs for RPM build
>> 
>> In the spec file, why do you BuildRequire uglify-js only on Fedora?
> 
> uglifyjs is not packaged for RHEL, which is the other platform our
> spec file targets, so we can't really BuildRequire it there.

I was afraid that was the reason ;-)

> 
>> Does that mean that if you build elsewhere, you may end up with a
>> build that minifies or not depending on whether uglifyjs is in path or not?
> 
> Yeah. Luckily we're not going with these patches but with Martin's
> approach instead, which neatly sidesteps this issue :)

OK.

> 
> -- 
> Andrea Bolognani / Red Hat / Virtualization
> 
> --
> libvir-list mailing list
> libvir-list at redhat.com
> https://www.redhat.com/mailman/listinfo/libvir-list





More information about the libvir-list mailing list