[libvirt] [PATCH 1/2] qemu: monitor: Remove text monitor support for cpu hot(un)plug

[Ján Tomko]

On Thu, Jun 20, 2019 at 01:22:26PM +0200, Peter Krempa wrote:
>The "cpu-add" command is supported in all supported qemu versions and
>cpu unplug did not work at all until the new cpu unplug approach (using
>device_add/del) was implemented.
>
>Remove the support for falling back to the text monitor.
>
>Signed-off-by: Peter Krempa <pkrempa at redhat.com>
>---
> src/qemu/qemu_monitor_json.c | 15 ++++-----------
> 1 file changed, 4 insertions(+), 11 deletions(-)
>
>diff --git a/src/qemu/qemu_monitor_json.c b/src/qemu/qemu_monitor_json.c
>index 4eca75ecc9..6d4f119a35 100644
>--- a/src/qemu/qemu_monitor_json.c
>+++ b/src/qemu/qemu_monitor_json.c
>@@ -2979,8 +2979,9 @@ int qemuMonitorJSONSetCPU(qemuMonitorPtr mon,
>                                          "i:id", cpu,
>                                          NULL);
>     } else {
>-        /* offlining is not yet implemented in qmp */
>-        goto fallback;
>+        virReportError(VIR_ERR_INTERNAL_ERROR, "%s",
>+                       _("vCPU unplug is not supported by this qemu"));

s/qemu/QEMU/

>+        goto cleanup;
>     }
>     if (!cmd)
>         goto cleanup;

Reviewed-by: Ján Tomko <jtomko at redhat.com>

Jano
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20190620/572c577f/attachment-0001.sig>