[libvirt] [PATCH v3 1/2] docs: Use our own implementation for fetching the RSS data

[Martin Kletzander]

On Thu, Jun 20, 2019 at 03:24:10PM +0200, Andrea Bolognani wrote:
>On Thu, 2019-06-20 at 15:00 +0200, Martin Kletzander wrote:
>[...]
>>      <script type="text/javascript">
>>        <!--
>> -      jQuery(function($) {
>> -        $("#planet").rss("http://planet.virt-tools.org/atom.xml", {
>> -          ssl: true,
>> -          layoutTemplate: '<dl>{entries}</dl>',
>> -          entryTemplate: '<dt><a href="{url}">{title}</a></dt><dd>by {author} on {date}</li>',
>> -          dateFormat: 'DD MMM YYYY'
>> -        })
>> -      })
>> -      // -->
>> +      window.addEventListener("load", function() { fetchRSS() });
>> +  // -->
>
>Still not aligned properly...
>
>[...]
>> +        if (this.status != 200) {
>> +            console.error(this.statusText)
>
>Missing semicolon.
>
>
>I could not test this locally, obviously, and I'm not sure how you
>could have either?
>

I have set up a local server which supplies the correct headers and then changed
"planet.virt-tools.org" to "localhost:8080".  Before posting I reverted the url
change back.  I also set up libvirt.org to point to localhost, but I still could
not test that because I would have to set up certificates for the httpd on
localhost.  And I already spend too much time on this.

>Assuming you have made sure it works correctly before posting,
>
>  Reviewed-by: Andrea Bolognani <abologna at redhat.com>
>
>-- 
>Andrea Bolognani / Red Hat / Virtualization
>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20190620/968763fe/attachment-0001.sig>