[libvirt] [PATCH] virStorageSourceChainHasManagedPR: Check propely

[Eric Blake]

On 6/21/19 11:11 AM, Michal Privoznik wrote:

s/propely/properly in the subject

> In the virStorageSourceChainHasManagedPR() function we iterate
> over whole backing chain trying to determine if one of the layers
> has managed PR configured. But due to a typo we in fact check the
> top layer only.
> 
> Signed-off-by: Michal Privoznik <mprivozn at redhat.com>
> ---
> 
> Pushed under trivial rule.

Oh well, my review is too late.

> 
>  src/util/virstoragefile.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/src/util/virstoragefile.c b/src/util/virstoragefile.c
> index 2b1c0a5b8e..f7495ab6da 100644
> --- a/src/util/virstoragefile.c
> +++ b/src/util/virstoragefile.c
> @@ -2083,7 +2083,7 @@ virStorageSourceChainHasManagedPR(virStorageSourcePtr src)
>      virStorageSourcePtr n;
>  
>      for (n = src; virStorageSourceIsBacking(n); n = n->backingStore) {
> -        if (virStoragePRDefIsManaged(src->pr))
> +        if (virStoragePRDefIsManaged(n->pr))
>              return true;
>      }
>  
> 

-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3226
Virtualization:  qemu.org | libvirt.org

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: OpenPGP digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20190621/8ab72f18/attachment-0001.sig>