[libvirt] [PATCH 1/4] tests: Normalize quotes for *-graphics

Ján Tomko jtomko at redhat.com
Tue Jun 25 18:37:04 UTC 2019


On Fri, Jun 14, 2019 at 10:04:36AM +0200, Andrea Bolognani wrote:
>Right now *-headless and *-graphics tests are using different
>quoting styles, which results in the diff between them being
>basically useless, whereas we would like it to be possible to
>compare these files directly and easily spot the differences.
>
>Convert all *-graphics tests to single quotes, which is the
>overwhelmingly more popular style

Irrelevant.

>and also the one libvirt
>itself uses when formatting XML,

This is the argument worth mentioning.

>which is a fact that will
>come in handy later.
>
>Signed-off-by: Andrea Bolognani <abologna at redhat.com>
>---
> .../aarch64-virt-graphics.xml                 | 50 ++++++++---------
> .../ppc64-pseries-graphics.xml                | 48 ++++++++--------
> tests/qemuxml2argvdata/s390x-ccw-graphics.xml | 46 +++++++--------
> tests/qemuxml2argvdata/x86_64-pc-graphics.xml | 56 +++++++++----------
> .../qemuxml2argvdata/x86_64-q35-graphics.xml  | 56 +++++++++----------
> 5 files changed, 128 insertions(+), 128 deletions(-)
>

Reviewed-by: Ján Tomko <jtomko at redhat.com>

Jano
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20190625/3a1cf2f6/attachment-0001.sig>


More information about the libvir-list mailing list