[libvirt] [PATCH 2/4] Revert "error: Add VIR_ERR_DEPRECATED error code"

Ján Tomko jtomko at redhat.com
Wed Jun 26 17:21:14 UTC 2019


On Wed, Jun 26, 2019 at 04:54:41PM +0100, Daniel P. Berrangé wrote:
>This reverts commit 226094fbc483128c8888f4171c353aed738b8346.
>
>A deprecation is a warning to something that use of a feature is
>being discouraged. By definition it is not an error condition to
>continue to use a deprecated feature.
>

Makes sense that from an app's PoV it's the same

>A VIR_ERR_DEPRECATED constant thus makes no conceptual sense. For
>features which are entirely absent we already document that the
>VIR_ERR_NO_SUPPORT code will be used. There is no need to distinguish
>between a feature which never existed and a feature which previously
>existed and was since removed.
>
>Signed-off-by: Daniel P. Berrangé <berrange at redhat.com>
>---
> include/libvirt/virterror.h | 1 -
> src/util/virerror.c         | 4 ----
> 2 files changed, 5 deletions(-)
>

Reviewed-by: Ján Tomko <jtomko at redhat.com>

Jano
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20190626/1acf87cd/attachment-0001.sig>


More information about the libvir-list mailing list