[libvirt] [PATCH 1/4] qemu: delete methods which are no longer supported
Peter Krempa
pkrempa at redhat.com
Thu Jun 27 06:02:54 UTC 2019
On Wed, Jun 26, 2019 at 16:54:40 +0100, Daniel Berrange wrote:
> The public API entry points will report VIR_ERR_NO_SUPPORT to the
> caller when a driver does not provide an implementation of a particular
> method.
>
> Signed-off-by: Daniel P. Berrangé <berrange at redhat.com>
> ---
> src/qemu/qemu_driver.c | 31 -------------------------------
> 1 file changed, 31 deletions(-)
[...]
> @@ -22271,7 +22242,6 @@ static virHypervisorDriver qemuHypervisorDriver = {
> .domainGetSecurityLabelList = qemuDomainGetSecurityLabelList, /* 0.10.0 */
> .nodeGetSecurityModel = qemuNodeGetSecurityModel, /* 0.6.1 */
> .domainGetXMLDesc = qemuDomainGetXMLDesc, /* 0.2.0 */
> - .connectDomainXMLFromNative = qemuConnectDomainXMLFromNative, /* 0.6.4 (deprecated: 5.5.0) */
This makes documentation strictly worse, where users may be lead into
thinking that this never existed.
I don't think we should just delete it without acknowledging we've
deleted it.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20190627/2765fe09/attachment-0001.sig>
More information about the libvir-list
mailing list