[libvirt] [PATCH 1/4] qemu: delete methods which are no longer supported

Andrea Bolognani abologna at redhat.com
Thu Jun 27 08:29:02 UTC 2019


On Thu, 2019-06-27 at 08:02 +0200, Peter Krempa wrote:
> On Wed, Jun 26, 2019 at 16:54:40 +0100, Daniel Berrange wrote:
> > @@ -22271,7 +22242,6 @@ static virHypervisorDriver qemuHypervisorDriver = {
> >      .domainGetSecurityLabelList = qemuDomainGetSecurityLabelList, /* 0.10.0 */
> >      .nodeGetSecurityModel = qemuNodeGetSecurityModel, /* 0.6.1 */
> >      .domainGetXMLDesc = qemuDomainGetXMLDesc, /* 0.2.0 */
> > -    .connectDomainXMLFromNative = qemuConnectDomainXMLFromNative, /* 0.6.4 (deprecated: 5.5.0) */
> 
> This makes documentation strictly worse, where users may be lead into
> thinking that this never existed.
> 
> I don't think we should just delete it without acknowledging we've
> deleted it.

FWIW, I completely agree with Peter.

-- 
Andrea Bolognani / Red Hat / Virtualization




More information about the libvir-list mailing list