[libvirt] [PATCH 1/4] qemu: delete methods which are no longer supported

[Daniel P. Berrangé]

On Thu, Jun 27, 2019 at 08:02:54AM +0200, Peter Krempa wrote:
> On Wed, Jun 26, 2019 at 16:54:40 +0100, Daniel Berrange wrote:
> > The public API entry points will report VIR_ERR_NO_SUPPORT to the
> > caller when a driver does not provide an implementation of a particular
> > method.
> > 
> > Signed-off-by: Daniel P. Berrangé <berrange at redhat.com>
> > ---
> >  src/qemu/qemu_driver.c | 31 -------------------------------
> >  1 file changed, 31 deletions(-)
> 
> [...]
> 
> > @@ -22271,7 +22242,6 @@ static virHypervisorDriver qemuHypervisorDriver = {
> >      .domainGetSecurityLabelList = qemuDomainGetSecurityLabelList, /* 0.10.0 */
> >      .nodeGetSecurityModel = qemuNodeGetSecurityModel, /* 0.6.1 */
> >      .domainGetXMLDesc = qemuDomainGetXMLDesc, /* 0.2.0 */
> > -    .connectDomainXMLFromNative = qemuConnectDomainXMLFromNative, /* 0.6.4 (deprecated: 5.5.0) */
> 
> This makes documentation strictly worse, where users may be lead into
> thinking that this never existed.
> 
> I don't think we should just delete it without acknowledging we've
> deleted it.

A documentation problem we can address pretty easily while keeping
these code semantics. eg

  .connectDomainXMLFromNative = NULL, /* 0.6.4 - 5.5.0 */

then just adapt your docs patch which read the deprecated comment to
require the version range when it sees a NULL method impl.

Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|