[libvirt] [PATCH v2] tools/virt-host-validate: Fix IOMMU check on s390x

Bjoern Walk bwalk at linux.ibm.com
Fri Mar 1 13:17:20 UTC 2019


Thomas Huth <thuth at redhat.com> [2019-03-01, 12:10PM +0100]:
> When running virt-host-validate on an s390x host, the tool currently warns
> that it is "Unknown if this platform has IOMMU support". We can use the
> common check for entries in /sys/kernel/iommu_groups here, too, but it only
> makes sense to check it if there are also PCI devices available. It's also
> common on s390x that there are no PCI devices assigned to the LPAR, and in
> that case there is no need for the PCI-related IOMMU, so without PCI devices
> we should simply skip this test.
> 
> Signed-off-by: Thomas Huth <thuth at redhat.com>
> ---
>  v2:
>  - Use virDirOpen() + virDirRead() instead of stat() - this should hopefully
>    work now as expected.

This seems to work fine.

Reviewed-by: Bjoern Walk <bwalk at linux.ibm.com>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 902 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20190301/b950b51e/attachment-0001.sig>


More information about the libvir-list mailing list