[libvirt] [jenkins-ci PATCH v6 4/4] mappings: mark packages using foreign arch for cross builds

Daniel P. Berrangé berrange at redhat.com
Fri Mar 1 17:09:37 UTC 2019


On Fri, Mar 01, 2019 at 06:03:04PM +0100, Andrea Bolognani wrote:
> On Thu, 2019-02-28 at 15:53 +0000, Daniel P. Berrangé wrote:
> [...]
> >    apparmor:
> >      deb: libapparmor-dev
> > +    cross-policy-Debian: foreign
> 
> Maybe we should use 'cross-policy-deb' instead? It's true that
> we're only doing cross compilation on Debian at the moment, but if
> we wanted to extend that to Ubuntu at some point this information
> should still be accurate for the most part...

I went back & forth on this. Originally I had 'deb' for everything
except the few packages which were excluded on Ubuntu, where I had
used 'Debian'. So I made it consistent. I guess it doesn't actually
harm to just use 'deb' for everything even if it doesn't exist on
Ubuntu

> [...]
> >    libgovirt:
> >      rpm: libgovirt-devel
> >      Debian: libgovirt-dev
> >      Debian8:
> > +    cross-policy-Debianian: foreign
> 
> s/Debianian/Debian/ ;)

Opps, missed this as this package isn't used by libvirt, only
virt-viewer

> 
> Unless you agree with the above, of course.
> 
> 
> Either way,
> 
>   Reviewed-by: Andrea Bolognani <abologna at redhat.com>
> 
> -- 
> Andrea Bolognani / Red Hat / Virtualization
> 

Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|




More information about the libvir-list mailing list