[libvirt] New Feature: Intel MKTME Support

[Mohammed, Karimullah]

Hi Daniel,

Thank you for answering our questions. We will soon send our design documentation for a review/discussion for MKTME enablement. This is not a complex feature , but in any case we wanted to start off with a design review , so that we get approved forehand for what we will be implementing.

I would like to take liberty in asking you question related to Libvirt, I did ask this question in IRC channel did not get any responses.

Can Libvirt directly make an kernel system call? i.e for a XML request if we have to make a kernel syscall, can we directly make kernel syscall in Libvirt or do we have to go through QEMU to process the request. We would like to know the norm of calling kernel system calls in Libvirt.

Thanks
karim



-----Original Message-----
From: Daniel P. Berrangé [mailto:berrange at redhat.com] 
Sent: Monday, March 4, 2019 1:47 PM
To: Mohammed, Karimullah <karimullah.mohammed at intel.com>
Cc: Carvalho, Larkins L <larkins.l.carvalho at intel.com>; libvir-list at redhat.com
Subject: Re: [libvirt] New Feature: Intel MKTME Support

On Mon, Mar 04, 2019 at 07:54:30PM +0000, Mohammed, Karimullah wrote:
> Hi Daniel,
> QEMU/KVM work is in process of completion and would be published soon 
> for the community approval(somewhere in March). We are working closely 
> with development team of KVM/QEMU. Meanwhile, we wanted to start the 
> process in Libvirt community.
> We will submit the work status of QEMU/KVM as they are available. 
> 
> We are new to the Libvirt community and wanted to know more about the 
> Libvirt design approval process, and wanted to kick start our work
> 
> Question we have are
> 1. What is the blueprint or design template for a feature approval?.
> 2. Procedure and requirements for design and code approval.

There's no formal process mandated for libvirt. Either people just send code patches directly, or for more complex features like this, start off with a mailing list discussion about design decisions before writing patches. Libvirt releases once a month so there's no critical deadlines you need to rush to meet from upstream POV - they'll merge in whatever release is next once the code has passed review. For complex code it is common to post several versions adapting to review comments.

In terms of merging code, if it depends on QEMU, then we require that the QEMU impl is merged before the libvirt impl is merged. We'd encourage you to develop & publish libvirt patches before QEMU work is finalized.
This helps demonstrate that the QEMU impl is a good match for what libvirt needs.

> 3. we wanted to use Libvirt MKTME in Openstack, what are the requirements?

This is probably more a question for the OpenStack community to answer.
The goal with Libvirt is to expose the feature in XML and/or API in a way that is suitable for any mgmt application.

Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|