[libvirt] [PATCH 2/2] conf: Accept model=virtio for SCSI controllers

Daniel P. Berrangé berrange at redhat.com
Tue Mar 5 15:12:57 UTC 2019


On Tue, Mar 05, 2019 at 04:07:40PM +0100, Andrea Bolognani wrote:
> At the moment, all VirtIO devices support model=virtio except
> for SCSI controllers where model=virtio-scsi must be used
> instead: get rid of this inconsistency by providing an alias
> at the parser level, so that existing code keeps working but
> using the same values across the board is also optionally
> possible.
> 
> Tweak one of the test cases to show that the new value is
> accepted transparently, without altering any of the output
> files in the process.

As in previous discussions of a similar type, I'm against adding
multiple names for the 100% functionally identical devices.

Previous naming choices from the past might not have been the
best in retrospect, but that's not a reason to make future XML
docs incompatible with existing libvirt by adding a 2nd different
name for something that's alread suppprted.

Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|




More information about the libvir-list mailing list