[libvirt] [PATCH 1/2] conf: Rename VIR_DOMAIN_CONTROLLER_MODEL_SCSI_VIRTIO_SCSI

[Ján Tomko]

On Tue, Mar 05, 2019 at 04:07:39PM +0100, Andrea Bolognani wrote:
>While the string associated with the enum value is virtio-scsi,
>having the string "SCSI" show up twice in the name of the enum
>value is unnecessary and needlessly deviates from the by now

It is not needless, it is for consistency with the already established
model name which is 'virtio-scsi', not 'virtio'.

Jano

>well established practice of having
>
>  MODEL_(VIRTIO|VIRTIO_TRANSITIONAL|VIRTIO_NON_TRANSITIONAL)
>
>enum values for VirtIO devices.
>
>Signed-off-by: Andrea Bolognani <abologna at redhat.com>
>---
> src/conf/domain_conf.c         | 2 +-
> src/conf/domain_conf.h         | 2 +-
> src/qemu/qemu_command.c        | 2 +-
> src/qemu/qemu_domain.c         | 6 +++---
> src/qemu/qemu_domain_address.c | 6 +++---
> src/qemu/qemu_process.c        | 2 +-
> src/vbox/vbox_common.c         | 2 +-
> src/vz/vz_utils.c              | 4 ++--
> 8 files changed, 13 insertions(+), 13 deletions(-)
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20190305/3ab17339/attachment-0001.sig>