[libvirt] [PATCH 01/23] util: xml: Enforce return value check from virXMLFormatElement

Peter Krempa pkrempa at redhat.com
Wed Mar 6 08:20:26 UTC 2019


The function does not transfer errors from 'attrBuf' and 'childBuf'
arguments into 'buf', but rather reports them right away, thus we need
to make sure that it's always checked.t

Signed-off-by: Peter Krempa <pkrempa at redhat.com>
---
 src/util/virxml.h | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/src/util/virxml.h b/src/util/virxml.h
index 78a1e7fa5e..b91fedde82 100644
--- a/src/util/virxml.h
+++ b/src/util/virxml.h
@@ -217,7 +217,8 @@ int
 virXMLFormatElement(virBufferPtr buf,
                     const char *name,
                     virBufferPtr attrBuf,
-                    virBufferPtr childBuf);
+                    virBufferPtr childBuf)
+    ATTRIBUTE_RETURN_CHECK;

 struct _virXPathContextNodeSave {
     xmlXPathContextPtr ctxt;
-- 
2.20.1




More information about the libvir-list mailing list