[libvirt] [PATCH] qemu: Don't set migration caps when changing postcopy bandwidth

[Peter Krempa]

On Wed, Mar 06, 2019 at 12:15:08 +0100, Jiri Denemark wrote:
> The qemuMigrationParamsApply internal API was designed to apply all
> migration parameters and capabilities before we start to migrate a
> domain. The API can also be called outside migration job, e.g., via a
> call to qemuDomainMigrateSetMaxSpeed with

Is it expected that if it's called inside the migration job and the caps
bitmap is empty the monitor command will be called with an empty array?

> VIR_DOMAIN_MIGRATE_MAX_SPEED_POSTCOPY flag, but in that case it should
> only apply migration parameters and ignore capabilities.

ACK, but the wording is weird. You don't really ignore any caps because
you explicitly reject it. I presume the problem is in the fact that if
migration is not running the API does not have efect.

Obviously v2 required if the problem is actually that the monitor
command is unhappy with empty array as the argument.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20190306/5418cb31/attachment-0001.sig>