[libvirt] [PATCH 18/23] conf: Avoid formatting empty <capabilities> element
Ján Tomko
jtomko at redhat.com
Wed Mar 6 11:56:34 UTC 2019
On Wed, Mar 06, 2019 at 09:20:43AM +0100, Peter Krempa wrote:
>If none of the 'capabilities' features are enabled we'd still format the
>opening and closing tag for the <capabilities element.
>
>The implementation is suboptimal but will be refactored for a better
>approach. This is done prior to the refactor to show that tests are not
>impacted.
>
>Signed-off-by: Peter Krempa <pkrempa at redhat.com>
>---
> src/conf/domain_conf.c | 9 ++++++++-
> tests/lxcconf2xmldata/lxcconf2xml-blkiotune.xml | 3 +--
> tests/lxcconf2xmldata/lxcconf2xml-cpusettune.xml | 3 +--
> tests/lxcconf2xmldata/lxcconf2xml-cputune.xml | 3 +--
> tests/lxcconf2xmldata/lxcconf2xml-idmap.xml | 3 +--
> tests/lxcconf2xmldata/lxcconf2xml-macvlannetwork.xml | 3 +--
> tests/lxcconf2xmldata/lxcconf2xml-memtune.xml | 3 +--
> tests/lxcconf2xmldata/lxcconf2xml-miscnetwork.xml | 3 +--
> tests/lxcconf2xmldata/lxcconf2xml-nonenetwork.xml | 3 +--
> tests/lxcconf2xmldata/lxcconf2xml-nonetwork.xml | 3 +--
> tests/lxcconf2xmldata/lxcconf2xml-physnetwork.xml | 3 +--
> tests/lxcconf2xmldata/lxcconf2xml-vlannetwork.xml | 3 +--
> 12 files changed, 19 insertions(+), 23 deletions(-)
>
Reviewed-by: Ján Tomko <jtomko at redhat.com>
Jano
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20190306/d3fe0ee7/attachment-0001.sig>
More information about the libvir-list
mailing list