[libvirt] [PATCH 1/3] tests: use virTestCompareToFile in storagepoolcapstest

Pavel Hrdina phrdina at redhat.com
Wed Mar 6 18:16:46 UTC 2019


This will allow to use VIR_TEST_REGENERATE_OUTPUT.

Signed-off-by: Pavel Hrdina <phrdina at redhat.com>
---
 tests/storagepoolcapstest.c | 7 +------
 1 file changed, 1 insertion(+), 6 deletions(-)

diff --git a/tests/storagepoolcapstest.c b/tests/storagepoolcapstest.c
index d31f50c957..ade586bcdd 100644
--- a/tests/storagepoolcapstest.c
+++ b/tests/storagepoolcapstest.c
@@ -68,16 +68,11 @@ test_virStoragePoolCapsFormat(const void *opaque)
                     abs_srcdir, data->filename) < 0)
         goto cleanup;
 
-    if (virFileReadAll(path, 8192, &poolCapsFromFile) < 0)
-        goto cleanup;
-
     if (!(poolCapsXML = virStoragePoolCapsFormat(poolCaps)))
         goto cleanup;
 
-    if (STRNEQ(poolCapsFromFile, poolCapsXML)) {
-        virTestDifference(stderr, poolCapsFromFile, poolCapsXML);
+    if (virTestCompareToFile(poolCapsXML, path) < 0)
         goto cleanup;
-    }
 
     ret = 0;
 
-- 
2.20.1




More information about the libvir-list mailing list