[libvirt] [PATCH 1/5] util: Rename virFileHasSuffix() to virStringHasCaseSuffix()
Peter Krempa
pkrempa at redhat.com
Thu Mar 7 08:00:25 UTC 2019
On Wed, Mar 06, 2019 at 17:54:00 +0100, Andrea Bolognani wrote:
> Despite its name, this is really just a general-purpose string
> manipulation function, so it should be moved to the virstring
> module and renamed accordingly.
>
> In addition to the obvious s/File/String/, also tweak the name
> to make it clear that the presence of the suffix is verified
> using case-insensitive comparison.
How about also adding a function comment with it?
>
> A few trivial whitespace changes are squashed in.
>
> Signed-off-by: Andrea Bolognani <abologna at redhat.com>
ACK.
You could also fix the return value type.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20190307/024ee3d2/attachment-0001.sig>
More information about the libvir-list
mailing list