[libvirt] [PATCH v3 01/18] qemu: Refactor snapshot check for _LIVE vs. _REDEFINE

[Ján Tomko]

On Mon, Mar 04, 2019 at 09:34:28PM -0600, Eric Blake wrote:
>The current qemu code rejects the combination of the two flags
>VIR_DOMAIN_SNAPSHOT_CREATE_LIVE in tandem with
>VIR_DOMAIN_SNAPSHOT_CREATE_REDEFINE, but rather late in the cycle
>(after the snapshot was already parsed), and with a rather confusing
>message (complaining that live snapshots require external storage,
>even if the redefined snapshot already declares external storage).
>Hoist the rejection message to occur earlier (before parsing any
>XML, which also aids upcoming patches that will implement bulk
>redefine), and with a more typical error message about mutually
>exclusive flags.
>
>Signed-off-by: Eric Blake <eblake at redhat.com>
>Reviewed-by: John Ferlan <jferlan at redhat.com>
>---
> src/qemu/qemu_driver.c | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
>

Reviewed-by: Ján Tomko <jtomko at redhat.com>

Jano
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20190307/c23fed08/attachment-0001.sig>