[libvirt] [jenkins-ci PATCH 3/3] lcitool: add support for --debug / -d argument

[Andrea Bolognani]

On Tue, 2019-03-12 at 10:49 +0000, Daniel P. Berrangé wrote:
> Introduce a --debug / -d argument that allows the display of information
> relevant to developers debugging problems. Initially this just displays
> the top level exception catch, so that full stack traces are shown.
> 
> Signed-off-by: Daniel P. Berrangé <berrange at redhat.com>
> ---
>  guests/lcitool | 14 ++++++++++----
>  1 file changed, 10 insertions(+), 4 deletions(-)
> 
> diff --git a/guests/lcitool b/guests/lcitool
> index 2c86d07..d8a3aca 100755
> --- a/guests/lcitool
> +++ b/guests/lcitool
> @@ -350,6 +350,9 @@ class Application:
>              description="libvirt CI guest management tool",
>          )
>  
> +        self._parser.add_argument("--debug", "-d", action="store_true",
> +                                  help="display debugging information")

Can you leave out the short option? We might want to use '-d' for
something more useful later on, and when debugging having to type
a few more letters is not a big deal.


Either way,

  Reviewed-by: Andrea Bolognani <abologna at redhat.com>

-- 
Andrea Bolognani / Red Hat / Virtualization