[libvirt] [PATCH 3/5] test: Support topological visits

[Daniel P. Berrangé]

On Tue, Mar 12, 2019 at 05:04:37PM +0100, Ján Tomko wrote:
> On Fri, Mar 08, 2019 at 12:05:10AM -0600, Eric Blake wrote:
> > snapshot_conf does all the hard work, the test driver just has to
> > accept the new flag.
> > 
> > Signed-off-by: Eric Blake <eblake at redhat.com>
> > ---
> > src/test/test_driver.c | 6 ++++++
> > 1 file changed, 6 insertions(+)
> > 
> > diff --git a/src/test/test_driver.c b/src/test/test_driver.c
> > index ef754658f3..02cd4f4d07 100644
> > --- a/src/test/test_driver.c
> > +++ b/src/test/test_driver.c
> > @@ -5960,6 +5960,7 @@ testDomainSnapshotNum(virDomainPtr domain, unsigned int flags)
> >     int n;
> > 
> >     virCheckFlags(VIR_DOMAIN_SNAPSHOT_LIST_ROOTS |
> > +                  VIR_DOMAIN_SNAPSHOT_LIST_TOPOLOGICAL |
> >                   VIR_DOMAIN_SNAPSHOT_FILTERS_ALL, -1);
> > 
> >     if (!(vm = testDomObjFromDomain(domain)))
> > @@ -5981,6 +5982,7 @@ testDomainSnapshotListNames(virDomainPtr domain,
> >     int n;
> > 
> >     virCheckFlags(VIR_DOMAIN_SNAPSHOT_LIST_ROOTS |
> > +                  VIR_DOMAIN_SNAPSHOT_LIST_TOPOLOGICAL |
> >                   VIR_DOMAIN_SNAPSHOT_FILTERS_ALL, -1);
> > 
> >     if (!(vm = testDomObjFromDomain(domain)))
> > @@ -6002,6 +6004,7 @@ testDomainListAllSnapshots(virDomainPtr domain,
> >     int n;
> > 
> >     virCheckFlags(VIR_DOMAIN_SNAPSHOT_LIST_ROOTS |
> > +                  VIR_DOMAIN_SNAPSHOT_LIST_TOPOLOGICAL |
> >                   VIR_DOMAIN_SNAPSHOT_FILTERS_ALL, -1);
> > 
> >     if (!(vm = testDomObjFromDomain(domain)))
> > @@ -6024,6 +6027,7 @@ testDomainSnapshotListChildrenNames(virDomainSnapshotPtr snapshot,
> >     int n = -1;
> > 
> >     virCheckFlags(VIR_DOMAIN_SNAPSHOT_LIST_DESCENDANTS |
> > +                  VIR_DOMAIN_SNAPSHOT_LIST_TOPOLOGICAL |
> >                   VIR_DOMAIN_SNAPSHOT_FILTERS_ALL, -1);
> > 
> >     if (!(vm = testDomObjFromSnapshot(snapshot)))
> > @@ -6049,6 +6053,7 @@ testDomainSnapshotNumChildren(virDomainSnapshotPtr snapshot,
> >     int n = -1;
> > 
> >     virCheckFlags(VIR_DOMAIN_SNAPSHOT_LIST_DESCENDANTS |
> > +                  VIR_DOMAIN_SNAPSHOT_LIST_TOPOLOGICAL |
> >                   VIR_DOMAIN_SNAPSHOT_FILTERS_ALL, -1);
> > 
> >     if (!(vm = testDomObjFromSnapshot(snapshot)))
> > @@ -6074,6 +6079,7 @@ testDomainSnapshotListAllChildren(virDomainSnapshotPtr snapshot,
> >     int n = -1;
> > 
> >     virCheckFlags(VIR_DOMAIN_SNAPSHOT_LIST_DESCENDANTS |
> > +                  VIR_DOMAIN_SNAPSHOT_LIST_TOPOLOGICAL |
> >                   VIR_DOMAIN_SNAPSHOT_FILTERS_ALL, -1);
> > 
> >     if (!(vm = testDomObjFromSnapshot(snapshot)))
> 
> I'd rather drop the non-ListAll versions.

Dropping them neeedlessly creates an inconsistency in the APIs. Right
now it is clear that all the APIs accept all the enums constants.

Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|