[libvirt] [PATCH 1/8] tests: Introduce testQemuDataInit() and testQemuDataReset()
Andrea Bolognani
abologna at redhat.com
Wed Mar 13 09:29:52 UTC 2019
On Wed, 2019-03-13 at 10:12 +0100, Peter Krempa wrote:
> Actually I don't see the reason for anything in this patch. Each
> function is called exactly once, so splitting it out does not make much
> sense without any further justification.
>
> The need to reset data->ret to 0 is not enough of a justification.
Better code organization: instead of having a bunch of initialization
and cleanup steps sprinkled throughout main(), we give them their own
functions and keep main() simple, clean and focused.
--
Andrea Bolognani / Red Hat / Virtualization
More information about the libvir-list
mailing list