[libvirt] [PATCH v3 2/2] conf: Use virStringParseYesNo()

Erik Skultety eskultet at redhat.com
Wed Mar 13 11:59:55 UTC 2019


On Wed, Mar 13, 2019 at 03:30:11PM +0900, Shotaro Gotanda wrote:
> this commit remove redundant common pattern in our XML parsing.

I appreciate splitting the changes for review purposes, most of the time it's a
very good practice which makes the reviewer's life easier, but this was a very
simple helper with only a handful of replacements, so IMO we can squash this
patch into the previous one (there wasn't much to be put into the commit
message anyway, so I reckon that's a good indicator :))

I'll squash it into the previous one before pushing:
Reviewed-by: Erik Skultety <eskultet at redhat.com>




More information about the libvir-list mailing list