[libvirt] [PATCH 1/3] tests: Turn virFileWrapperAddPrefix to void

Martin Kletzander mkletzan at redhat.com
Wed Mar 13 13:10:11 UTC 2019


On Wed, Mar 13, 2019 at 11:13:07AM +0100, Michal Privoznik wrote:
>In theory, it's nice to have virFileWrapperAddPrefix() return a
>value that indicates if the function succeeded or not. But in
>practice, nobody checks for that and in fact blindly believes
>that the function succeeded. Therefore, make the function return
>nothing and just abort() if it would fail.
>
>Signed-off-by: Michal Privoznik <mprivozn at redhat.com>
>---
> tests/virfilewrapper.c | 13 +++++++------
> tests/virfilewrapper.h |  2 +-
> 2 files changed, 8 insertions(+), 7 deletions(-)
>

Reviewed-by: Martin Kletzander <mkletzan at redhat.com>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20190313/2e704127/attachment-0001.sig>


More information about the libvir-list mailing list