[libvirt] [PATCH] test: Drop a few unnecessary <source> elements added by virt-install

[Erik Skultety]

On Wed, Mar 13, 2019 at 10:04:27AM +0100, Andrea Bolognani wrote:
> On Wed, 2019-03-13 at 09:42 +0100, Erik Skultety wrote:
> > The <source mode='bind'/> elements were added in commit 4d7ea75e and
> > apparently generated by virt-install, but since the @path attribute
> > is missing, the element will never be formatted back to the XML which the
> > libvirt-go-xml-check expects, so it fails.
> > The lack of the @path attribute is not a problem in general, because we
> > can autogenerate the path in certain cases, so qemuxml2argvtest will
> > always be happy, but XML formatting is a different thing.
> >
> > Therefore, drop these generated elements, as they're unnecessary for the
> > purposes of qemuxml2argvtest and won't mess with the XML formatting
> > test in Go.
> >
> > Signed-off-by: Erik Skultety <eskultet at redhat.com>
> > ---
> >
> > Additionally, I could introduce a xml2xml test here, but I already spent enough
> > time hunting the CI failure down between libvirt and libvirt-go so this was the
> > simplest solution which doesn't require any extra work.
>
> I'm okay with the change, so
>
>   Reviewed-by: Andrea Bolognani <abologna at redhat.com>
>
> but I wonder if this is the expected behavior for the Go XML
> parsing and formatting code?

So, since Dan fixed it properly within libvirt-go-xml with commit c834a236,
this is a sNACK then.

Erik