[libvirt] [PATCH 8/8] Don't define abs_* variables ourselves

Andrea Bolognani abologna at redhat.com
Wed Mar 13 16:51:23 UTC 2019


Apparently this was necessary in the past because old versions
of autoconf/automake didn't make them available, but these
days all of the platforms we target include recent enough
autotools - as evidenced by the fact that, for example, we
already use abs_top_srcdir in tools/ despite the fact that
tools/Makefile.am is missing the same boilerplate.

Signed-off-by: Andrea Bolognani <abologna at redhat.com>
---
 src/Makefile.am   | 6 ------
 tests/Makefile.am | 6 ------
 2 files changed, 12 deletions(-)

diff --git a/src/Makefile.am b/src/Makefile.am
index 0d3d231889..4294bd1c6c 100644
--- a/src/Makefile.am
+++ b/src/Makefile.am
@@ -16,12 +16,6 @@
 ## License along with this library.  If not, see
 ## <http://www.gnu.org/licenses/>.
 
-# old automake does not provide abs_{src,build}dir variables
-abs_builddir = $(shell pwd)
-abs_top_builddir = $(shell cd .. && pwd)
-abs_srcdir = $(shell cd $(srcdir) && pwd)
-abs_top_srcdir = $(shell cd $(top_srcdir) && pwd)
-
 # No libraries with the exception of LIBXML should be listed
 # here. List them against the individual XXX_la_CFLAGS targets
 # that actually use them.
diff --git a/tests/Makefile.am b/tests/Makefile.am
index 858ed047e8..7ce327c9e8 100644
--- a/tests/Makefile.am
+++ b/tests/Makefile.am
@@ -16,12 +16,6 @@
 ## License along with this library.  If not, see
 ## <http://www.gnu.org/licenses/>.
 
-# old automake does not provide abs_{src,build}dir variables
-abs_builddir = $(shell pwd)
-abs_top_builddir = $(shell cd .. && pwd)
-abs_srcdir = $(shell cd $(srcdir) && pwd)
-abs_top_srcdir = $(shell cd $(top_srcdir) && pwd)
-
 SHELL = $(PREFERABLY_POSIX_SHELL)
 
 AM_CPPFLAGS = \
-- 
2.20.1




More information about the libvir-list mailing list