[libvirt] [PATCH 10/21] tests: qemuxml2argv: remove DO_TEST_PARSE_FLAGS_ERROR

Cole Robinson crobinso at redhat.com
Thu Mar 14 14:44:03 UTC 2019


It only has one caller. Just use DO_TEST_FULL

Signed-off-by: Cole Robinson <crobinso at redhat.com>
---
 tests/qemuxml2argvtest.c | 13 ++++---------
 1 file changed, 4 insertions(+), 9 deletions(-)

diff --git a/tests/qemuxml2argvtest.c b/tests/qemuxml2argvtest.c
index 070f7f0a05..1ce8bade48 100644
--- a/tests/qemuxml2argvtest.c
+++ b/tests/qemuxml2argvtest.c
@@ -876,12 +876,6 @@ mymain(void)
                  ARG_FLAGS, FLAG_EXPECT_PARSE_ERROR | FLAG_EXPECT_FAILURE, \
                  ARG_QEMU_CAPS, __VA_ARGS__)
 
-# define DO_TEST_PARSE_FLAGS_ERROR(name, parseFlags, ...) \
-    DO_TEST_FULL(name, \
-                 ARG_PARSEFLAGS, parseFlags, \
-                 ARG_FLAGS, FLAG_EXPECT_PARSE_ERROR | FLAG_EXPECT_FAILURE, \
-                 ARG_QEMU_CAPS, __VA_ARGS__)
-
 # define NONE QEMU_CAPS_LAST
 
     /* Unset or set all envvars here that are copied in qemudBuildCommandLine
@@ -2887,9 +2881,10 @@ mymain(void)
     /* VM XML has invalid arch/ostype/virttype combo, but the SKIP flag
      * will avoid the error. Still, we expect qemu driver to complain about
      * missing machine error, and not crash */
-    DO_TEST_PARSE_FLAGS_ERROR("missing-machine",
-                              VIR_DOMAIN_DEF_PARSE_SKIP_VALIDATE,
-                              NONE);
+    DO_TEST_FULL("missing-machine",
+                 ARG_FLAGS, FLAG_EXPECT_PARSE_ERROR | FLAG_EXPECT_FAILURE,
+                 ARG_PARSEFLAGS, VIR_DOMAIN_DEF_PARSE_SKIP_VALIDATE,
+                 ARG_QEMU_CAPS, NONE);
 
     DO_TEST("name-escape",
             QEMU_CAPS_NAME_DEBUG_THREADS,
-- 
2.20.1




More information about the libvir-list mailing list