[libvirt] [PATCH 1/4] conf: Add a new 'xenbus' controller type

[Jim Fehlig]

On 3/13/19 7:17 PM, Eric Blake wrote:
> On 3/8/19 5:05 PM, Jim Fehlig wrote:
>> xenbus is virtual controller (akin to virtio controllers) for Xen
>> paravirtual devices. Although all Xen VMs have a xenbus, it has
>> never been modeled in libvirt, or in Xen native VM config format
>> for that matter.
>>
>> Recently there have been requests to support Xen's max_grant_frames
>> setting in libvirt. max_grant_frames is best modeled as an attribute
>> of xenbus. It describes the maximum IO buffer space (or DMA space)
>> available in xenbus for use by connected paravirtual devices. This
>> patch introduces a new xenbus controller type that includes a
>> maxGrantFrames attribute.
>>
>> Signed-off-by: Jim Fehlig <jfehlig at suse.com>
>> ---
> 
> With this patch applied, I'm now getting compilation failures on Fedora
> 29 with gcc 8.3.1:
> 
> vbox/vbox_common.c: In function 'vboxSetStorageController':
> vbox/vbox_common.c:355:5: error: enumeration value
> 'VIR_DOMAIN_CONTROLLER_TYPE_XENBUS' not handled in switch [-Werror=switch]
>       switch ((virDomainControllerType) controller->type) {
>       ^~~~~~
>    CC       vbox/libvirt_driver_vbox_impl_la-vbox_storage.lo

Opps, I had the vbox driver disabled :-(. I just verified there are no other 
spots I missed due to disabled code.

> I'm pushing this as the obvious fix under the build-breaker rule:

Thanks!

Regards,
Jim

> 
> diff --git i/src/vbox/vbox_common.c w/src/vbox/vbox_common.c
> index c410514d37..b8dfb55ef4 100644
> --- i/src/vbox/vbox_common.c
> +++ w/src/vbox/vbox_common.c
> @@ -377,6 +377,7 @@ vboxSetStorageController(virDomainControllerDefPtr
> controller,
>       case VIR_DOMAIN_CONTROLLER_TYPE_CCID:
>       case VIR_DOMAIN_CONTROLLER_TYPE_USB:
>       case VIR_DOMAIN_CONTROLLER_TYPE_PCI:
> +    case VIR_DOMAIN_CONTROLLER_TYPE_XENBUS:
>       case VIR_DOMAIN_CONTROLLER_TYPE_LAST:
>           virReportError(VIR_ERR_CONFIG_UNSUPPORTED,
>                          _("The vbox driver does not support %s
> controller type"),
> 
>